{"id":"GHSA-v745-5q22-55f6","aliases":[],"summary":"OpenBao signer honours BAO_*/VAULT_* environment, including SKIP_VERIFY and proxy settings","published_at":"2026-10-13T09:24:59Z","modified_at":"2026-10-13T09:24:59Z","products":[{"slug":"puppet","name":"Puppet / OpenVox","category":"iac"}],"rating":{"severity":"medium","score":6.8,"vector":"CVSS:3.1/AV:A/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N","attack_path":"adjacent","user_interaction":false,"malicious":false},"fix_available":true,"kev":{"listed":false,"ransomware":false},"public_exploit":false,"exploits":[],"priority":6.8,"record_count":1,"vendors":["GitHub"],"details":"The OpenBao Transit signer builds its client with `api.DefaultConfig()`, which reads the `BAO_*` environment (falling back to `VAULT_*`). Before commit `6740ab96dc28`, nothing documented this or reported it. A stray `VAULT_SKIP_VERIFY=1` in the signer's environment silently turned off server certificate verification on the connection that carries the AppRole login and the signing token.\r\n\r\nFound in an independent audit at `fb856f1` and re-checked against `main` at `145cb53` with `openbao/api/v2 v2.7.1`.\r\n\r\n## Where\r\n\r\nLine numbers are as of `145cb53`, before the fix.\r\n\r\n- `internal/signer/openbao/client.go:31`: `openBaoCfg := api.DefaultConfig()`. `DisableEnvironment` is never set.\r\n- In `openbao/api/v2@v2.7.1`, `DefaultConfig` calls `ReadEnvironment()` (`client.go:401-406`). That reads `BAO_SKIP_VERIFY` (`:585-590`), `BAO_PROXY_ADDR` and `BAO_HTTP_PROXY` (`:604-611`), `BAO_TOKEN` (`:820-821`) and others. `ReadBaoVariable` (`env.go:22-34`) falls back to the `VAULT_*` names.\r\n- The later `ConfigureTLS` call only ever sets `InsecureSkipVerify = true` (`client.go:463-465`). It never clears a value the environment already set.\r\n- The signer child gets `signerEnv(baseEnv)` (`cmd/openvox-ca/launcher.go:143`), which removes only `NOTIFY_SOCKET`, so these variables reach it.\r\n\r\n`docs/openbao-transit.md` and `docs/configuration.md` listed the `PUPPET_CA_OPENBAO_*` settings and said nothing about `BAO_*` or `VAULT_*`.\r\n\r\n## Reproduction\r\n\r\nOn a build before the fix, start the signer with `VAULT_SKIP_VERIFY=1` against an OpenBao endpoint that presents a certificate the configured CA file does not trust. The connection succeeds, and nothing is logged.\r\n\r\n## Impact\r\n\r\n`VAULT_SKIP_VERIFY` and `VAULT_ADDR`-style variables are common in developer shells, CI runners and container base environments. If one leaks into the CA's unit file or pod spec, an on-path attacker can take the Transit token and sign anything as the CA. `BAO_PROXY_ADDR` redirects the connection outright. Before the fix, nothing in the logs or docs pointed the operator at the cause.\r\n\r\n## Fix\r\n\r\nFixed on `main` on 2026-10-13 in commit [`6740ab96dc2843497067948808ae11141bc9a35f`](https://github.com/voxpupuli/openvox-ca/commit/6740ab96dc2843497067948808ae11141bc9a35f) (PR #482, closes #474), Go module version `v0.0.0-20261013091901-6740ab96dc28`.\r\n\r\nopenvox-ca deliberately keeps honouring the OpenBao client's environment, the same variables the `bao` CLI reads, so that an administrator can still use them. Ignoring them outright would remove a standard way to configure the client. Instead, the fix makes them visible:\r\n\r\n- The signer logs a separate `WARN` line, beginning \"OpenBao server certificate verification is OFF\", whenever `BAO_SKIP_VERIFY` or `VAULT_SKIP_VERIFY` has turned verification off. It also names `openbao.tls_ca_file` as overridden when that is set.\r\n- Every other variable in effect gets a `WARN` line saying what it changes and which `openbao` setting, if any, it overrides. A variable that is set but superseded by openvox-ca's own configuration gets an `INFO` line. Variables are logged by name only, because `BAO_TOKEN` and the certificate variables can hold secrets.\r\n- If the environment stops the client being built at all, the startup error lists the variables that were set, and withholds any URL the environment supplied.\r\n- `docs/openbao-transit.md` now has a table of every variable the client reads, what it controls and whether the environment or openvox-ca wins. `BAO_SKIP_VERIFY` always wins: no openvox-ca setting turns verification back on. `docs/configuration.md` points to the table.\r\n- Specs fail if an upgrade of the OpenBao client library starts reading a variable the table does not list.\r\n\r\n## What to do\r\n\r\nMove to a build that includes `6740ab96dc28` (2026-10-13 or later), and check the signer's startup log for \"OpenBao server certificate verification is OFF\" and \"OpenBao client setting taken from the environment\". A clean environment logs neither. Remove any `BAO_*` or `VAULT_*` variable you did not intend from the CA's unit file, container image or pod spec.\r\n\r\nOn any build, `env | grep -E '^(BAO|VAULT)_'` in the signer's environment shows what the client will read.","affected_stack":[{"ecosystem":"Go","package":"github.com/voxpupuli/openvox-ca","ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"fixed":"0.0.0-20261013091901-6740ab96dc28"}]}],"fixed":["0.0.0-20261013091901-6740ab96dc28"],"provider":"github-repo-advisories","source":"GHSA-v745-5q22-55f6","relation":"self"}],"affected_other":[],"product_status":[],"records":[{"provider":"github-repo-advisories","source_id":"GHSA-v745-5q22-55f6","relation":"self","url":"https://github.com/voxpupuli/openvox-ca/security/advisories/GHSA-v745-5q22-55f6","license":"GitHub Terms of Service","published_at":"2026-10-13T09:24:59Z","modified_at":"2026-10-13T09:24:59Z","summary":"OpenBao signer honours BAO_*/VAULT_* environment, including SKIP_VERIFY and proxy settings","details":"The OpenBao Transit signer builds its client with `api.DefaultConfig()`, which reads the `BAO_*` environment (falling back to `VAULT_*`). Before commit `6740ab96dc28`, nothing documented this or reported it. A stray `VAULT_SKIP_VERIFY=1` in the signer's environment silently turned off server certificate verification on the connection that carries the AppRole login and the signing token.\r\n\r\nFound in an independent audit at `fb856f1` and re-checked against `main` at `145cb53` with `openbao/api/v2 v2.7.1`.\r\n\r\n## Where\r\n\r\nLine numbers are as of `145cb53`, before the fix.\r\n\r\n- `internal/signer/openbao/client.go:31`: `openBaoCfg := api.DefaultConfig()`. `DisableEnvironment` is never set.\r\n- In `openbao/api/v2@v2.7.1`, `DefaultConfig` calls `ReadEnvironment()` (`client.go:401-406`). That reads `BAO_SKIP_VERIFY` (`:585-590`), `BAO_PROXY_ADDR` and `BAO_HTTP_PROXY` (`:604-611`), `BAO_TOKEN` (`:820-821`) and others. `ReadBaoVariable` (`env.go:22-34`) falls back to the `VAULT_*` names.\r\n- The later `ConfigureTLS` call only ever sets `InsecureSkipVerify = true` (`client.go:463-465`). It never clears a value the environment already set.\r\n- The signer child gets `signerEnv(baseEnv)` (`cmd/openvox-ca/launcher.go:143`), which removes only `NOTIFY_SOCKET`, so these variables reach it.\r\n\r\n`docs/openbao-transit.md` and `docs/configuration.md` listed the `PUPPET_CA_OPENBAO_*` settings and said nothing about `BAO_*` or `VAULT_*`.\r\n\r\n## Reproduction\r\n\r\nOn a build before the fix, start the signer with `VAULT_SKIP_VERIFY=1` against an OpenBao endpoint that presents a certificate the configured CA file does not trust. The connection succeeds, and nothing is logged.\r\n\r\n## Impact\r\n\r\n`VAULT_SKIP_VERIFY` and `VAULT_ADDR`-style variables are common in developer shells, CI runners and container base environments. If one leaks into the CA's unit file or pod spec, an on-path attacker can take the Transit token and sign anything as the CA. `BAO_PROXY_ADDR` redirects the connection outright. Before the fix, nothing in the logs or docs pointed the operator at the cause.\r\n\r\n## Fix\r\n\r\nFixed on `main` on 2026-10-13 in commit [`6740ab96dc2843497067948808ae11141bc9a35f`](https://github.com/voxpupuli/openvox-ca/commit/6740ab96dc2843497067948808ae11141bc9a35f) (PR #482, closes #474), Go module version `v0.0.0-20261013091901-6740ab96dc28`.\r\n\r\nopenvox-ca deliberately keeps honouring the OpenBao client's environment, the same variables the `bao` CLI reads, so that an administrator can still use them. Ignoring them outright would remove a standard way to configure the client. Instead, the fix makes them visible:\r\n\r\n- The signer logs a separate `WARN` line, beginning \"OpenBao server certificate verification is OFF\", whenever `BAO_SKIP_VERIFY` or `VAULT_SKIP_VERIFY` has turned verification off. It also names `openbao.tls_ca_file` as overridden when that is set.\r\n- Every other variable in effect gets a `WARN` line saying what it changes and which `openbao` setting, if any, it overrides. A variable that is set but superseded by openvox-ca's own configuration gets an `INFO` line. Variables are logged by name only, because `BAO_TOKEN` and the certificate variables can hold secrets.\r\n- If the environment stops the client being built at all, the startup error lists the variables that were set, and withholds any URL the environment supplied.\r\n- `docs/openbao-transit.md` now has a table of every variable the client reads, what it controls and whether the environment or openvox-ca wins. `BAO_SKIP_VERIFY` always wins: no openvox-ca setting turns verification back on. `docs/configuration.md` points to the table.\r\n- Specs fail if an upgrade of the OpenBao client library starts reading a variable the table does not list.\r\n\r\n## What to do\r\n\r\nMove to a build that includes `6740ab96dc28` (2026-10-13 or later), and check the signer's startup log for \"OpenBao server certificate verification is OFF\" and \"OpenBao client setting taken from the environment\". A clean environment logs neither. Remove any `BAO_*` or `VAULT_*` variable you did not intend from the CA's unit file, container image or pod spec.\r\n\r\nOn any build, `env | grep -E '^(BAO|VAULT)_'` in the signer's environment shows what the client will read.","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:A/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N","source":"GHSA-v745-5q22-55f6"}],"affected":[{"ecosystem":"Go","package":"github.com/voxpupuli/openvox-ca","ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"fixed":"0.0.0-20261013091901-6740ab96dc28"}]}],"fixed":["0.0.0-20261013091901-6740ab96dc28"],"provider":"github-repo-advisories","source":"GHSA-v745-5q22-55f6","relation":"self"}],"product_status":[],"references":[{"type":"ADVISORY","url":"https://github.com/voxpupuli/openvox-ca/security/advisories/GHSA-v745-5q22-55f6"}]}],"references":[{"type":"ADVISORY","url":"https://github.com/voxpupuli/openvox-ca/security/advisories/GHSA-v745-5q22-55f6"}],"sources":[{"provider":"github-repo-advisories","source_id":"GHSA-v745-5q22-55f6","url":"https://github.com/voxpupuli/openvox-ca/security/advisories/GHSA-v745-5q22-55f6","license":"GitHub Terms of Service","modified_at":"2026-10-13T09:24:59Z","relation":"self"}]}
